-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Adds new formats that use the new scalar formats from lucene #141601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benwtrent
wants to merge
18
commits into
elastic:lucene_snapshot
Choose a base branch
from
benwtrent:add-new-scalar-formats
base: lucene_snapshot
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adds new formats that use the new scalar formats from lucene #141601
benwtrent
wants to merge
18
commits into
elastic:lucene_snapshot
from
benwtrent:add-new-scalar-formats
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Member
Author
|
Here is the difference in recall/etc. this PR (1, 2, 4, 7) bits, all using the new format baseline: (1, 4, 7) Obviously, 2, 4 are way better. Single bit might be a little slower. But int7 is significantly slower due to lack of native code support. Recall is better across the board. |
…search into add-new-scalar-formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>non-issue
:Search Relevance/Vectors
Vector search
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
v9.4.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new ES formats that build on the Lucene formats.
This adds scorers & scorer suppliers.