[DRAFT] Delay rescoring vectors in DFS knn search #141742
Draft
+721
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring_vectors_in_dfs
pmpailis
commented
Feb 3, 2026
| throw new IllegalArgumentException("oversample must be greater than 1"); | ||
| } | ||
| if (oversampleValue < 1 && oversampleValue != 0) { | ||
| if (oversampleValue <= 1 && oversampleValue != 0) { |
Contributor
Author
There was a problem hiding this comment.
We specify in our docs that oversample must be greater than 1 or exactly 0 so changed the check to be in sync.
…:pmpailis/elasticsearch into gh_139445_delay_rescoring_vectors_in_dfs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139445