[Inference API] Handle preconfigured endpoints with embedding task type #141788
+126
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows ElasticInferenceServiceAuthorizationModel to handle proconfigured endpoints with the new embedding task type where previously an error would have been logged.
DonalEvans
added
>enhancement
Feature:GenAI
DonalEvans
changed the title
Collaborator
|
Pinging @elastic/search-inference-team (Team:Search - Inference) |
Contributor
jonathan-buttner
left a comment
jonathan-buttner
left a comment
There was a problem hiding this comment.
Looks good, just one question about the EIS task type path.
| nameDense, | ||
| idDenseMultimodal, | ||
| nameDenseMultimodal, | ||
| createTaskTypeObject(EIS_TEXT_EMBED_PATH, TaskType.EMBEDDING.toString()), |
Contributor
There was a problem hiding this comment.
Should we be using EIS_MULTIMODAL_EMBED_PATH instead of EIS_TEXT_EMBED_PATH?
Contributor
Author
There was a problem hiding this comment.
Yes, good catch. The test passes either way, but that's no reason not to be correct.
Contributor
jonathan-buttner
left a comment
jonathan-buttner
left a comment
There was a problem hiding this comment.
Actually, how about we add an embedding example to the auth response in this variable:
EIS_AUTHORIZATION_RESPONSE_V2.
That'll probably cause some test failures that'll need EMBEDDING added to an enum set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows ElasticInferenceServiceAuthorizationModel to handle proconfigured endpoints with the new embedding task type where previously an error would have been logged.