-
Notifications
You must be signed in to change notification settings - Fork 33
github-actions: build docker images #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label. Could you fix it @v1v? 🙏
|
honour the env variable instead
Some failures
See #6 |
to be supported in the future
@@ -18,18 +18,28 @@ endif | |||
|
|||
# Requires login at google storage. | |||
copy-npcap: | |||
@echo 'cp gs://$(GS_BUCKET_PATH)/private/$(NPCAP_FILE)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for debugging purposes only
endif | ||
|
||
# Requires login at google storage. | ||
copy-sdks: | ||
@echo 'cp gs://$(GS_BUCKET_PATH)/sdks' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for debugging purposes only
ifeq ($(CI),true) | ||
@gcloud storage cp gs://ingest-buildkite-ci/sdks . --recursive | ||
@gcloud storage cp gs://$(GS_BUCKET_PATH)/sdks . --recursive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
honour the variable
@@ -7,7 +7,7 @@ NPCAP_VERSION := 1.80 | |||
NPCAP_FILE := npcap-$(NPCAP_VERSION)-oem.exe | |||
SUFFIX_NPCAP_VERSION := -npcap-$(NPCAP_VERSION) | |||
NPCAP_REPOSITORY := docker.elastic.co/observability-ci | |||
GS_BUCKET_PATH ?= ingest-buildkite-ci | |||
GS_BUCKET_PATH ?= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unset, so we are forced to set it always
💚 Build Succeeded
History
|
💚 Build Succeeded
History
|
💚 Build Succeeded
History
|
What
Use GH workflows to create the docker images.
Why
vs
Caveats
This won't work for PRs from forked repositories and can not access GH secrets.
Tasks
push
in main or any branchesFollow up