-
Notifications
You must be signed in to change notification settings - Fork 500
Remove Security Category Tag from Non-Security Packages #15611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JDKurma
wants to merge
11
commits into
elastic:main
Choose a base branch
from
JDKurma:remove-miscategorized-security-tags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+0
−10
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5b28f03
Remove security category tag from non-security packages
JDKurma e5dd75b
Add back 'security' category
JDKurma b332ed4
Add back 'security' category
JDKurma e3168d0
Add security category back to manifest.yml
JDKurma c2e56b3
Add security category back to manifest.yml
JDKurma c92f88d
revert comment change
JDKurma ec75bb4
revert comment change
JDKurma b918827
Merge branch 'main' into remove-miscategorized-security-tags
trisch-me 9d42d2b
Merge branch 'main' into remove-miscategorized-security-tags
trisch-me 081acaf
Add back 'security'
JDKurma 5ccbd87
Merge branch 'main' into remove-miscategorized-security-tags
trisch-me File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,10 +6,6 @@ type: integration | |
categories: | ||
- datastore | ||
- observability | ||
# Added database_security category as it collects database logs and metrics including collection statistics, database statistics, and replication status | ||
- database_security | ||
# Added global security category as this integration collects security-relevant data | ||
- security | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks fine |
||
icons: | ||
- src: /img/logo_mongodb.svg | ||
title: logo mongodb | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,10 +7,6 @@ type: integration | |
categories: | ||
- datastore | ||
- observability | ||
# Added database_security category as it collects error logs, slow query logs, and replication status metrics that are relevant for database security monitoring | ||
- database_security | ||
# Added global security category as this integration collects security-relevant data | ||
- security | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks fine |
||
conditions: | ||
kibana: | ||
version: "^8.15.0 || ^9.0.0" | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clement-fouque Do you recall why this was added as a security integration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we had a discussion but I don't remember why we added it. We can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is owned by security team, has it no security use case?