Clean up deprecated ESLint rules

.eslintrc.js

@@ -1544,12 +1544,11 @@ module.exports = {
         'no-lone-blocks': 'error',
         'no-multi-assign': 'error',
         'no-misleading-character-class': 'error',
-        'no-new-symbol': 'error',
+        'no-new-native-nonconstructor': 'error',
         'no-obj-calls': 'error',
         'no-param-reassign': 'error',
         'no-process-exit': 'error',
         'no-prototype-builtins': 'error',
-        'no-return-await': 'error',
         'no-self-compare': 'error',
         'no-shadow-restricted-names': 'error',
         'no-sparse-arrays': 'error',
@@ -1564,7 +1563,6 @@ module.exports = {
         'no-useless-computed-key': 'error',
         'no-useless-rename': 'error',
         'no-useless-return': 'error',
-        'one-var-declaration-per-line': 'error',
         'prefer-object-spread': 'error',
         'prefer-promise-reject-errors': 'error',
         'prefer-rest-params': 'error',
@@ -1861,12 +1859,11 @@ module.exports = {
         'no-lone-blocks': 'error',
         'no-multi-assign': 'error',
         'no-misleading-character-class': 'error',
-        'no-new-symbol': 'error',
+        'no-new-native-nonconstructor': 'error',
         'no-obj-calls': 'error',
         'no-param-reassign': ['error', { props: true }],
         'no-process-exit': 'error',
         'no-prototype-builtins': 'error',
-        'no-return-await': 'error',
         'no-self-compare': 'error',
         'no-shadow-restricted-names': 'error',
         'no-sparse-arrays': 'error',
@@ -1883,7 +1880,6 @@ module.exports = {
         'no-useless-rename': 'error',
         'no-useless-return': 'error',
         'no-void': 'error',
-        'one-var-declaration-per-line': 'error',
         'prefer-object-spread': 'error',
         'prefer-promise-reject-errors': 'error',
         'prefer-rest-params': 'error',
@@ -2387,7 +2383,6 @@ module.exports = {
             next: ['return'],
           },
         ],
-        'padded-blocks': ['error', 'always'],
         'arrow-body-style': ['error', 'as-needed'],
         'prefer-arrow-callback': 'error',
         'no-unused-vars': 'off',
@@ -2543,7 +2538,15 @@ module.exports = {
         'x-pack/platform/plugins/private/telemetry_collection_xpack/**',
       ],
       rules: {
-        '@typescript-eslint/prefer-ts-expect-error': 'error',
+        '@typescript-eslint/ban-ts-comment': [
+          'error',
+          {
+            'ts-check': false,
+            'ts-expect-error': false,
+            'ts-ignore': true,
+            'ts-nocheck': false,
+          },
+        ],
       },
     },
 
@@ -2588,12 +2591,11 @@ module.exports = {
         'no-lone-blocks': 'error',
         'no-multi-assign': 'error',
         'no-misleading-character-class': 'error',
-        'no-new-symbol': 'error',
+        'no-new-native-nonconstructor': 'error',
         'no-obj-calls': 'error',
         'no-param-reassign': 'error',
         'no-process-exit': 'error',
         'no-prototype-builtins': 'error',
-        'no-return-await': 'error',
         'no-self-compare': 'error',
         'no-shadow-restricted-names': 'error',
         'no-sparse-arrays': 'error',
@@ -2608,7 +2610,6 @@ module.exports = {
         'no-useless-computed-key': 'error',
         'no-useless-rename': 'error',
         'no-useless-return': 'error',
-        'one-var-declaration-per-line': 'error',
         'prefer-object-spread': 'error',
         'prefer-promise-reject-errors': 'error',
         'prefer-rest-params': 'error',
@@ -2766,17 +2767,6 @@ module.exports = {
       },
     },
 
-    /**
-     * Enterprise Search Prettier override
-     * Lints unnecessary backticks - @see https://github.com/prettier/eslint-config-prettier/blob/main/README.md#forbid-unnecessary-backticks
-     */
-    {
-      files: ['x-pack/solutions/search/plugins/enterprise_search/**/*.{ts,tsx}'],
-      rules: {
-        quotes: ['error', 'single', { avoidEscape: true, allowTemplateLiterals: false }],
-      },
-    },
-
     /**
      * Cloud Security Team overrides
      */

packages/kbn-eslint-config/react.js

@@ -52,7 +52,6 @@ module.exports = {
     'jsx-a11y/no-interactive-element-to-noninteractive-role': 'error',
     'jsx-a11y/no-noninteractive-element-interactions': 'error',
     'jsx-a11y/no-noninteractive-element-to-interactive-role': 'error',
-    'jsx-a11y/no-onchange': 'error',
     'jsx-a11y/no-redundant-roles': 'error',
     'jsx-a11y/role-has-required-aria-props': 'error',
     'jsx-a11y/role-supports-aria-props': 'error',

packages/kbn-eslint-config/typescript.js

@@ -184,7 +184,6 @@ module.exports = {
           '@typescript-eslint/no-namespace': 'error',
           '@typescript-eslint/no-shadow': 'error',
           // rely on typescript
-          '@typescript-eslint/no-undef': 'off',
           'no-undef': 'off',
 
           '@typescript-eslint/triple-slash-reference': [

x-pack/platform/packages/shared/file-upload/src/file_upload_component/new/mapping_editor/mapping_editor.test.tsx

@@ -38,7 +38,6 @@ jest.mock('@kbn/field-utils/src/components/field_select/field_select', () => ({
     onTypeChange: (type: string) => void;
   }) => {
     return (
-      // eslint-disable-next-line jsx-a11y/no-onchange
       <select
         data-test-subj="field-type-select"
         value={selectedType || ''}

x-pack/platform/packages/shared/response-ops/alerting-v2-rule-form/flyout/compose_discover/compose_discover_flyout.test.tsx

@@ -148,7 +148,6 @@ jest.mock('./query_sandbox_flyout', () => ({
         <div data-test-subj="mockSandboxHelpText">{props.helpText}</div>
         <div data-test-subj="mockSandboxHeaderActions">{props.headerActions}</div>
         {props.onTimeFieldChange ? (
-          // eslint-disable-next-line jsx-a11y/no-onchange
           <select
             data-test-subj="querySandboxTimeField"
             value={props.timeField}