[Chrome Next] Migrate spaces to AppHeader

[kowalczyk-krzysztof]

Summary

This PR migrates Spaces pages to the new AppHeader.

Part of: https://github.com/elastic/kibana-team/issues/3945

Visuals

Classic

Before

spaces_classic_before.mov

After

spaces_classic_after.mov

Solution

Before

spaces_solution_before.mov

After

spaces_solution_after.mov

[infra-vault-gh-plugin-prod]

Pinging @elastic/appex-sharedux (Team:SharedUX)

[jeramysoucy]

Header, badges and tabs all behave correctly in manual testing. Three things:

1. Spinner never shows while the space itself is loading. The space && conjunct in space && !isPageReady means that while space is undefined you get the fallback title over an empty body; the spinner only appears afterwards, during the features/roles fetch. Dropping space && should do it.

2. No coverage for the new header content. Nothing asserts the solution/current badges, the tab set, or the Permissions role-count badge.

3. The space avatar is removed from the header here as well (user avatar is also removed in user PR). In this case it may not be a concern since the avatar is rendered and editable in the body — unlike the user avatar in #288023, which is no longer rendered at all.

🤖 AI assisted review

[kowalczyk-krzysztof]

@jeramysoucy

Dropped the space && guard so the spinner shows while the space itself is loading, not only during the later features/roles fetch.

Added EditSpace tests for the header: solution + Current badges, the General settings / Permissions / Content tabs, and the Permissions role-count badge.

Left the space avatar in the body only - it’s still rendered and editable there.

[jeramysoucy]

Thanks for the update! The previous items are all addressed. Sorry, found a few things, mostly nits, but worth looking at before you merge.

[jeramysoucy]

Nit: label: solution is the raw enum value. It's inert today since SpaceSolutionBadge derives its own translated label and ignores badgeText. But renderCustomBadge is @deprecated and carries a TODO to remove custom JSX badges, so whoever does that cleanup will fall back to label and ship "oblt" instead of "Observability". Passing the translated solution name costs nothing and removes the trap.

[kowalczyk-krzysztof]

Addressed in: 533b95e

And just FYI, while renderCustomBadge is indeed deprecated, there are no plans to actually remove it anytime soon as this would require aligning with current consumers (the API was introduced so we could migrate DnD ASAP).

[kibanamachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 533b95e
• Build duration: 58 mins
• Storybooks Preview

Failed CI Steps

• FTR Configs #43
• Scout Lane #31 - stateful-classic / default

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
shared-plugins	11.9MB	11.9MB	-22.0B
spaces	21.5KB	21.5KB	+42.0B
total			+20.0B

Unknown metric groups

shared async chunks total size

id	before	after	diff
all	15.0MB	15.0MB	-734.0B

total optimizer output size

id	before	after	diff
all	63.0MB	63.0MB	-714.0B

Test Failures

• [job] [logs] FTR Configs #43 / console app text input with a data URI in the load_from query loads the data from the URI
• [job] [logs] Scout Lane #31 - stateful-classic / default / local-stateful-classic - Dataset quality - data stream stats across data stream types - returns the stats of every requested data stream type

History

• 💛 Build #494999 was flaky e709595
• 💛 Build #494467 was flaky df36818

cc @kowalczyk-krzysztof