Skip to content

[streams-ui] Fix auto-generated CODEOWNERS entries by updating kibana.jsonc owner fields - #288217

Open
Supplementing wants to merge 3 commits into
elastic:mainfrom
Supplementing:streams-ui/fix-codeowners-kibana-jsonc
Open

[streams-ui] Fix auto-generated CODEOWNERS entries by updating kibana.jsonc owner fields#288217
Supplementing wants to merge 3 commits into
elastic:mainfrom
Supplementing:streams-ui/fix-codeowners-kibana-jsonc

Conversation

@Supplementing

@Supplementing Supplementing commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Followup to #284546, which transferred CODEOWNERS ownership from @elastic/fleet to @elastic/streams-ui as part of the fleet → streams-ui team rename. The top section of CODEOWNERS is auto-generated from kibana.jsonc files via node scripts/generate codeowners — CI regenerated it after merge and reverted the 6 entries that live in that section, because the source kibana.jsonc files were never updated.

This PR fixes the root cause by updating the owner field in the 6 affected kibana.jsonc files and committing the regenerated CODEOWNERS output.

Affected packages/plugins:

  • x-pack/platform/plugins/shared/fleet
  • x-pack/platform/plugins/shared/fleet/cypress
  • src/platform/packages/shared/deeplinks/fleet
  • src/platform/packages/shared/kbn-yaml-loader
  • src/platform/plugins/shared/custom_integrations
  • x-pack/platform/packages/shared/kbn-elastic-agent-condition-language

All were solely owned by @elastic/fleet; no co-owners were affected.

Checklist

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

No significant risks identified — config-only change, no runtime behavior affected.

@Supplementing
Supplementing requested a review from a team as a code owner August 31, 2026 22:24
@Supplementing Supplementing added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:streams-ui Streams UI team labels Aug 31, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 6 kibana.jsonc owner edits and their matching CODEOWNERS lines look correct for the fleet → streams-ui rename. However, the regenerated CODEOWNERS also drops two unrelated ownership entries (flagged inline) that appear to be collateral from regenerating against a stale branch. Recommend rebasing on main and regenerating before merge.

Generated by Claude Reviewer for #288217 · opus · 99.9 AIC · ⌖ 14.4 AIC · ⊞ 5.1K

Comment thread .github/CODEOWNERS
Comment thread .github/CODEOWNERS
@Supplementing
Supplementing force-pushed the streams-ui/fix-codeowners-kibana-jsonc branch from f20f87c to af23402 Compare August 31, 2026 22:35
@Supplementing
Supplementing enabled auto-merge (squash) August 31, 2026 22:36
@Supplementing
Supplementing force-pushed the streams-ui/fix-codeowners-kibana-jsonc branch from 0893806 to 7bef28d Compare August 31, 2026 23:29

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 6 fleet→streams-ui owner changes in the kibana.jsonc files and their corresponding CODEOWNERS entries are consistent and correct. However, the two additional CODEOWNERS entry removals are not the stale-cleanup the description claims — both backing kibana.jsonc files still exist with valid owners at this PR's head commit. See inline comments; a rebase + regenerate should resolve it.

Generated by Claude Reviewer for #288217 · opus · 103.8 AIC · ⌖ 39.4 AIC · ⊞ 5.1K

Comment thread .github/CODEOWNERS
Comment thread .github/CODEOWNERS
@Supplementing
Supplementing force-pushed the streams-ui/fix-codeowners-kibana-jsonc branch from 070989e to c46a4ea Compare September 1, 2026 14:43
@Supplementing
Supplementing requested review from a team September 1, 2026 14:45
…streams-ui via kibana.jsonc

Update owner field in 6 kibana.jsonc files so that the auto-generated
section of CODEOWNERS reflects the fleet→streams-ui team rename.

Previous PR (elastic#284546) manually edited CODEOWNERS but the auto-generated
section is driven by kibana.jsonc; CI regenerated and reverted those lines.

Regenerated with: node scripts/generate codeowners

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Supplementing
Supplementing force-pushed the streams-ui/fix-codeowners-kibana-jsonc branch from 0609d85 to 8a8813f Compare September 1, 2026 17:22
@Supplementing
Supplementing removed request for a team September 1, 2026 17:24
@kibanamachine

kibanamachine commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:streams-ui Streams UI team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants