[9.3] (backport #18515) Fix, clean batch metrics on pipeline shutdown #18521
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup batch statistic metric when a pipeline is shutdown. Adds a test to verify that pipeline's shutdown (used during pipeline reload) clear the batch metrics, this is done in JavaPipeline#clear_pipeline_metrics method. (cherry picked from commit 1be3a35)
3 tasks
Contributor
🤖 GitHub commentsJust comment with:
|
💚 Build Succeeded
cc @andsel |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @andsel? 🙏 |
1 similar comment
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @andsel? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Cleanup batch statistic metric when a pipeline is shutdown.
What does this PR do?
Adds a test to verify that pipeline's shutdown (used during pipeline reload) clear the batch metrics, this is done in JavaPipeline#clear_pipeline_metrics method.
Why is it important/What is the impact to the user?
As a user I want that batch metrics doesn't get polluted during pipeline restarts.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
How to test this PR locally
Follow the steps documented in the originating #18512
Related issues
This is an automatic backport of pull request #18515 done by [Mergify](https://mergify.com).