-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Upgrade Log4j to 2.25.3 #18522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Upgrade Log4j to 2.25.3 #18522
+41
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jsvd
commented
Dec 19, 2025
- Use PluginProcessor explicitly to skip GraalVmProcessor
- Update test dependency from log4j-core:tests to log4j-core-test module
- Update test imports for relocated packages in Log4j 2.24+:
- org.apache.logging.log4j.junit -> org.apache.logging.log4j.core.test.junit
- org.apache.logging.log4j.test.appender -> org.apache.logging.log4j.core.test.appender
- Add @SuppressWarnings for deprecated Message.getFormat() and EventLogger
- Fix ObjectMappersTest to not assume fixed serializer ordering
- Use PluginProcessor explicitly to skip GraalVmProcessor - Update test dependency from log4j-core:tests to log4j-core-test module - Update test imports for relocated packages in Log4j 2.24+: - org.apache.logging.log4j.junit -> org.apache.logging.log4j.core.test.junit - org.apache.logging.log4j.test.appender -> org.apache.logging.log4j.core.test.appender - Add @SuppressWarnings for deprecated Message.getFormat() and EventLogger - Fix ObjectMappersTest to not assume fixed serializer ordering
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
|
This pull request does not have a backport label. Could you fix it @jsvd? 🙏
|
Member
Author
|
/run exhaustive tests |
ca-scribner
added a commit
to ca-scribner/advisories
that referenced
this pull request
Dec 29, 2025
To mitigate CVE-2025-14762, log4j must be bumped from 2.17.2 to 2.25.3. This includes navigating a few small breaking changes in log4j. Upstream is currently working on a patch to complete this migration [here](elastic/logstash#18522), but the patch is incomplete and has failing tests
ca-scribner
added a commit
to ca-scribner/advisories
that referenced
this pull request
Dec 29, 2025
To mitigate CVE-2025-14762, log4j must be bumped from 2.17.2 to 2.25.3. This includes navigating a few small breaking changes in log4j. Upstream is currently working on a patch to complete this migration [here](elastic/logstash#18522), but the patch is incomplete and has failing tests
ca-scribner
added a commit
to ca-scribner/advisories
that referenced
this pull request
Dec 29, 2025
To mitigate CVE-2025-14762, log4j must be bumped from 2.17.2 to 2.25.3. This includes navigating a few small breaking changes in log4j. Upstream is currently working on a patch to complete this migration [here](elastic/logstash#18522), but the patch is incomplete and has failing tests
ca-scribner
added a commit
to ca-scribner/advisories
that referenced
this pull request
Dec 29, 2025
To mitigate CVE-2025-14762, log4j must be bumped from 2.17.2 to 2.25.3. This includes navigating a few small breaking changes in log4j. Upstream is currently working on a patch to complete this migration [here](elastic/logstash#18522), but the patch is incomplete and has failing tests
ca-scribner
added a commit
to ca-scribner/advisories
that referenced
this pull request
Dec 29, 2025
To mitigate CVE-2025-14762, log4j must be bumped from 2.17.2 to 2.25.3. This includes navigating a few small breaking changes in log4j. Upstream is currently working on a patch to complete this migration [here](elastic/logstash#18522), but the patch is incomplete and has failing tests
github-merge-queue bot
pushed a commit
to wolfi-dev/advisories
that referenced
this pull request
Dec 30, 2025
To mitigate CVE-2025-14762, log4j must be bumped from 2.17.2 to 2.25.3. This includes navigating a few small breaking changes in log4j. Upstream is currently working on a patch to complete this migration [here](elastic/logstash#18522), but the patch is incomplete and has failing tests
💛 Build succeeded, but was flaky
Failed CI StepsHistory
|
robbavey
approved these changes
Jan 2, 2026
Member
robbavey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.