Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ElasticSearch] Fix sorting #1112

Merged
merged 1 commit into from
Feb 21, 2025
Merged

[ElasticSearch] Fix sorting #1112

merged 1 commit into from
Feb 21, 2025
+43 −16

Conversation

yansavitski
Copy link
Contributor

Description

Fix sorting when has sortField and sortDirection values in state

Associated Github Issues

#1109

@yansavitski yansavitski requested a review from a team as a code owner February 21, 2025 14:15
@yansavitski yansavitski linked an issue Feb 21, 2025 that may be closed by this pull request
[react-search-ui] setSort not working, Sorting not working #1109
Closed
TattdCodeMonkey
TattdCodeMonkey approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understood how sorting in SearchKit works then these changes LGTM. But I did not get a chance to test this myself.

@yansavitski yansavitski merged commit f9eca68 into main Feb 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[react-search-ui] setSort not working, Sorting not working
2 participants
@yansavitski @TattdCodeMonkey