Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: lint JS in Markdown #129

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

dsanders11
Copy link
Contributor

@dsanders11 dsanders11 commented Jun 14, 2023

Mostly whitespace, semis, and commas, but it did catch a couple of spots where there were mistakes with brackets, and did identify some code blocks that were using javascript when they should be using json for the language identifier.

Also threw in some changes from json to jsonc for language identifier when comments were present, as it is still recognized by GitHub and prevents the nasty dark red text background when viewing the code on GitHub.

@dsanders11 dsanders11 marked this pull request as ready for review June 14, 2023 02:05
@malept
Copy link
Contributor

malept commented Jun 14, 2023

I wonder if it is worth running something like a daily / weekly GitHub Action to execute prettier / lint-roller or something on the repo.

@dsanders11
Copy link
Contributor Author

Ah, I assume you mean to clean up the changes that come in from GitBook? Good point, those bypass any kind of linting requirement unfortunately. We probably should, although I remember it being a bit of a pain to do commits from a GitHub Action workflow. Will explore doing so in a future PR.

@dsanders11 dsanders11 merged commit 976b5a4 into electron-forge:v6 Jun 22, 2023
@dsanders11 dsanders11 deleted the markdown-standard-lint branch June 22, 2023 18:26
@dsanders11
Copy link
Contributor Author

I wonder if it is worth running something like a daily / weekly GitHub Action to execute prettier / lint-roller or something on the repo.

Paper-trailing, there's now an auto-fix workflow that runs on pushes to fix things coming in from GitBook when possible, via #151.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants