Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove deprecated tool property #178

Merged
merged 1 commit into from
May 28, 2024
Merged

docs: remove deprecated tool property #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions guides/code-signing/code-signing-macos.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,6 @@ For further reading on entitlements, see the following pages in Apple developer
Under the hood, Electron Forge uses the [`@electron/notarize`](https://github.com/electron/notarize) tool to notarize your macOS application.
{% endhint %}

The `osxNotarize` configuration object only supports `notarytool` as of Electron Forge v7.0.0.

The `notarytool` command has three authentication options, which are detailed below. Note that you will want to use a `forge.config.js` configuration so that you can load environment variables into your Forge config.

{% hint style="danger" %}
Expand Down Expand Up @@ -140,7 +138,6 @@ module.exports = {
packagerConfig: {
// ...
osxNotarize: {
tool: 'notarytool',
appleId: process.env.APPLE_ID,
appleIdPassword: process.env.APPLE_PASSWORD,
teamId: process.env.APPLE_TEAM_ID
Expand Down Expand Up @@ -174,7 +171,6 @@ module.exports = {
packagerConfig: {
// ...
osxNotarize: {
tool: 'notarytool',
appleApiKey: process.env.APPLE_API_KEY,
appleApiKeyId: process.env.APPLE_API_KEY_ID,
appleApiIssuer: process.env.APPLE_API_ISSUER
Expand Down Expand Up @@ -209,7 +205,6 @@ module.exports = {
packagerConfig: {
// ...
osxNotarize: {
tool: 'notarytool',
keychain: 'my-keychain',
keychainProfile: 'my-keychain-profile'
}
Expand All @@ -229,7 +224,6 @@ module.exports = {
packagerConfig: {
osxSign: {},
osxNotarize: {
tool: 'notarytool',
appleId: process.env.APPLE_ID,
appleIdPassword: process.env.APPLE_PASSWORD,
teamId: process.env.APPLE_TEAM_ID
Expand Down