Skip to content

Refine TitleBar props defaults and handlers #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xudafeng merged 1 commit into from
Dec 12, 2025
Merged

Refine TitleBar props defaults and handlers #19

xudafeng merged 1 commit into from
Dec 12, 2025

Conversation

@xudafeng
Copy link
Member

@xudafeng xudafeng commented Dec 12, 2025

Summary

  • make TitleBar props optional and inline default values for a smoother TypeScript experience
  • memoize icon sizing and handler callbacks and use functional maximize toggle to avoid stale state
  • correct the draggable area class name for clarity

Testing

  • not run (not requested)

Codex Task

@xudafeng xudafeng requested a review from z0gSh1u December 12, 2025 06:37
@xudafeng xudafeng merged commit c1e5b44 into main Dec 12, 2025
2 checks passed
@xudafeng xudafeng deleted the codex/optimize-pr-#16 branch December 12, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@z0gSh1u z0gSh1u Awaiting requested review from z0gSh1u

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xudafeng