Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump electronjs/node orb version to fix cache issue #128

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Aug 24, 2023

Fixes detecting of failed Node.js installs with nvm-windows and bumps the cache version to clear out a corrupted cache as a result of not detecting those failed installs. The cache key does not need to be explicitly bumped because the newest version of the orb changed the cache key format so it effectively changes the cache key.

Also bumps the Node.js v20 version and clears a note regarding that, now that the issue has been fixed upstream.

Refs https://app.circleci.com/pipelines/github/electron/chromedriver/209/workflows/2342bf81-1ee5-49fc-be87-b2901f0431ea/jobs/1079

@dsanders11 dsanders11 marked this pull request as ready for review August 24, 2023 01:27
@dsanders11 dsanders11 requested a review from a team as a code owner August 24, 2023 01:27
@dsanders11 dsanders11 merged commit dda0d89 into main Aug 24, 2023
4 checks passed
@dsanders11 dsanders11 deleted the fix-corrupted-cache branch August 24, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants