Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show when there are no release notes for a comparison #28

Merged
merged 1 commit into from
Dec 13, 2023
Merged

fix: show when there are no release notes for a comparison #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/routes/release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,18 @@ Handlebars.registerHelper('markdownMergeHeaders', function (contentArr) {
}
}
let generatedNotes = '# Combined Release Notes\n\n';
for (const knownSection of knownSections.concat(Object.keys(groups))) {
if (!groups[knownSection]) continue;
generatedNotes += `## ${knownSection}\n\n${groups[knownSection]}\n`;
delete groups[knownSection];

const hasReleaseNotes = Object.values(groups).some((v) => v !== '');
if (hasReleaseNotes) {
for (const knownSection of knownSections.concat(Object.keys(groups))) {
if (!groups[knownSection]) continue;
generatedNotes += `## ${knownSection}\n\n${groups[knownSection]}\n`;
delete groups[knownSection];
}
} else {
generatedNotes += 'There were no release notes for this version comparison.';
}

return DOMPurify.sanitize(md.render(generatedNotes));
});

Expand Down