Auto fit video in tile depending on orientation of the tile and the source stream#3756
Open
BillCarsonFr wants to merge 6 commits intolivekitfrom
Open
Auto fit video in tile depending on orientation of the tile and the source stream#3756BillCarsonFr wants to merge 6 commits intolivekitfrom
BillCarsonFr wants to merge 6 commits intolivekitfrom
Conversation
BillCarsonFr
force-pushed
the
valere/auto_fit_based_on_video_ratio
branch
from
0cca004 to
1de8d93
Compare
BillCarsonFr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the logic out to a specific file to make the merging of #3755 easier
Fixes https://github.com/element-hq/voip-internal/issues/468
Before
Mobile video (portrait) are zoomed on desktop (landscape) and the other way around.
It also makes the video looks pixelized
After
The manual option to fit to frame has been removed in favor of the smart default based on orientation
