Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-types to v19 (major) - autoclosed #28915

Closed
wants to merge 1 commit into from
+12 −13
Closed

Update react-types to v19 (major) - autoclosed #28915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -69,8 +69,8 @@
},
"resolutions": {
"@playwright/test": "1.51.0",
"@types/react": "18.3.18",
"@types/react-dom": "18.3.5",
"@types/react": "19.0.10",
"@types/react-dom": "19.0.4",
"oidc-client-ts": "3.2.0",
"jwt-decode": "4.0.0",
"caniuse-lite": "1.0.30001704",
@@ -207,9 +207,9 @@
"@types/node-fetch": "^2.6.2",
"@types/pako": "^2.0.0",
"@types/qrcode": "^1.3.5",
"@types/react": "18.3.18",
"@types/react": "19.0.10",
"@types/react-beautiful-dnd": "^13.0.0",
"@types/react-dom": "18.3.5",
"@types/react-dom": "19.0.4",
"@types/react-transition-group": "^4.4.0",
"@types/sanitize-html": "2.13.0",
"@types/semver": "^7.5.8",
17 changes: 8 additions & 9 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
@@ -3249,10 +3249,10 @@
dependencies:
"@types/react" "*"

"@types/react-dom@18.3.5":
version "18.3.5"
resolved "https://registry.yarnpkg.com/@types/react-dom/-/react-dom-18.3.5.tgz#45f9f87398c5dcea085b715c58ddcf1faf65f716"
integrity sha512-P4t6saawp+b/dFrUr2cvkVsfvPguwsxtH6dNIYRllMsefqFzkZk5UIjzyDOv5g1dXIPdG4Sp1yCR4Z6RCUsG/Q==
"@types/react-dom@19.0.4":
version "19.0.4"
resolved "https://registry.yarnpkg.com/@types/react-dom/-/react-dom-19.0.4.tgz#bedba97f9346bd4c0fe5d39e689713804ec9ac89"
integrity sha512-4fSQ8vWFkg+TGhePfUzVmat3eC14TXYSsiiDSLI0dVLsrm9gZFABjPy/Qu6TKgl1tq1Bu1yDsuQgY3A3DOjCcg==

"@types/react-redux@^7.1.20":
version "7.1.34"
@@ -3277,12 +3277,11 @@
"@types/prop-types" "*"
"@types/react" "*"

"@types/react@*", "@types/react@18.3.18":
version "18.3.18"
resolved "https://registry.yarnpkg.com/@types/react/-/react-18.3.18.tgz#9b382c4cd32e13e463f97df07c2ee3bbcd26904b"
integrity sha512-t4yC+vtgnkYjNSKlFx1jkAhH8LgTo2N/7Qvi83kdEaUtMDiwpbLAktKDaAMlRcJ5eSxZkH74eEGt1ky31d7kfQ==
"@types/react@*", "@types/react@19.0.10":
version "19.0.10"
resolved "https://registry.yarnpkg.com/@types/react/-/react-19.0.10.tgz#d0c66dafd862474190fe95ce11a68de69ed2b0eb"
integrity sha512-JuRQ9KXLEjaUNjTWpzuR231Z2WpIwczOkBEIvbHNCzQefFIT0L8IqE6NV6ULLyC1SI/i234JnDoMkfg+RjQj2g==
dependencies:
"@types/prop-types" "*"
csstype "^3.0.2"

"@types/[email protected]":

Unchanged files with check annotations Beta

View file
src/@types/common.ts
export type { NonEmptyArray, XOR, Writeable } from "matrix-js-sdk/src/matrix";
export type ComponentClass = keyof JSX.IntrinsicElements | JSXElementConstructor<any>;

Check failure on line 13 in src/@types/common.ts

GitHub Actions / Typescript Syntax Check 

Cannot find namespace 'JSX'.
export type { Leaves } from "matrix-web-i18n";
View file
src/HtmlUtils.tsx
const emojiToHtmlSpan = (emoji: string): string =>
`<span class='mx_Emoji' title='${unicodeToShortcode(emoji)}'>${emoji}</span>`;
const emojiToJsxSpan = (emoji: string, key: number): JSX.Element => (

Check failure on line 242 in src/HtmlUtils.tsx

GitHub Actions / Typescript Syntax Check 

Cannot find namespace 'JSX'.
<span key={key} className="mx_Emoji" title={unicodeToShortcode(emoji)}>
{emoji}
</span>
* @returns if isHtmlMessage is true, returns an array of strings, otherwise return an array of React Elements for emojis
* and plain text for everything else
*/
export function formatEmojis(message: string | undefined, isHtmlMessage?: false): JSX.Element[];

Check failure on line 256 in src/HtmlUtils.tsx

GitHub Actions / Typescript Syntax Check 

Cannot find namespace 'JSX'.
export function formatEmojis(message: string | undefined, isHtmlMessage: true): string[];
export function formatEmojis(message: string | undefined, isHtmlMessage?: boolean): (JSX.Element | string)[] {

Check failure on line 258 in src/HtmlUtils.tsx

GitHub Actions / Typescript Syntax Check 

Cannot find namespace 'JSX'.
const emojiToSpan = isHtmlMessage ? emojiToHtmlSpan : emojiToJsxSpan;
const result: (JSX.Element | string)[] = [];

Check failure on line 260 in src/HtmlUtils.tsx

GitHub Actions / Typescript Syntax Check 

Cannot find namespace 'JSX'.
if (!message) return result;
let text = "";
interface BodyToNodeReturn {
strippedBody: string;
formattedBody?: string;
emojiBodyElements: JSX.Element[] | undefined;

Check failure on line 418 in src/HtmlUtils.tsx

GitHub Actions / Typescript Syntax Check 

Cannot find namespace 'JSX'.
className: string;
}
formattedBody = formatEmojis(eventInfo.safeBody, true).join("");
}
let emojiBodyElements: JSX.Element[] | undefined;

Check failure on line 461 in src/HtmlUtils.tsx

GitHub Actions / Typescript Syntax Check 

Cannot find namespace 'JSX'.
if (!eventInfo.safeBody && eventInfo.bodyHasEmoji) {
emojiBodyElements = formatEmojis(eventInfo.strippedBody, false) as JSX.Element[];

Check failure on line 463 in src/HtmlUtils.tsx

GitHub Actions / Typescript Syntax Check 

Cannot find namespace 'JSX'.
}
return { strippedBody: eventInfo.strippedBody, formattedBody, emojiBodyElements, className };
View file
playwright/e2e/crypto/device-verification.spec.ts
/*

Check failure on line 1 in playwright/e2e/crypto/device-verification.spec.ts

GitHub Actions / Run Tests [Chrome] 1/6

[Chrome] › playwright/e2e/crypto/device-verification.spec.ts:121:9 › Device verification › Verify device with QR code during login @no-webkit 

  1) [Chrome] › playwright/e2e/crypto/device-verification.spec.ts:121:9 › Device verification › Verify device with QR code during login @no-webkit 
    Error: apiRequestContext.fetch: Target page, context or browser has been closed
    Call log:
      - → POST http://localhost:42679/_synapse/admin/v1/register
        - user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/134.0.6998.35 Safari/537.36
        - accept: */*
        - accept-encoding: gzip,deflate,br
        - content-type: application/json
        - content-length: 309

        at Api.request (/home/runner/work/element-web/element-web/node_modules/@element-hq/element-web-playwright-common/lib/utils/api.js:28:41)
        at StartedSynapseContainer.registerUserInternal (/home/runner/work/element-web/element-web/node_modules/@element-hq/element-web-playwright-common/lib/testcontainers/synapse.js:287:42)
        at Object.credentials (/home/runner/work/element-web/element-web/node_modules/@element-hq/element-web-playwright-common/lib/fixtures/user.js:16:29)
Copyright 2024 New Vector Ltd.
Copyright 2023 The Matrix.org Foundation C.I.C.
await page.route("**/_matrix/client/v3/sendToDevice/m.secret.request/**", async (route) => {
await route.fulfill({ json: {} });
await new Promise((f) => setTimeout(f, 1000));
await route.fetch();

Check failure on line 96 in playwright/e2e/crypto/device-verification.spec.ts

GitHub Actions / Run Tests [Chrome] 1/6

[Chrome] › playwright/e2e/crypto/device-verification.spec.ts:121:9 › Device verification › Verify device with QR code during login @no-webkit 

  1) [Chrome] › playwright/e2e/crypto/device-verification.spec.ts:121:9 › Device verification › Verify device with QR code during login @no-webkit 
    Error: "route.fetch: Test ended." while running route callback.
    Consider awaiting `await page.unrouteAll({ behavior: 'ignoreErrors' })`
    before the end of the test to ignore remaining routes in flight.

      94 |             await route.fulfill({ json: {} });
      95 |             await new Promise((f) => setTimeout(f, 1000));
    > 96 |             await route.fetch();
         |                         ^
      97 |         });
      98 |
      99 |         await logIntoElement(page, credentials);
        at /home/runner/work/element-web/element-web/playwright/e2e/crypto/device-verification.spec.ts:96:25
});
await logIntoElement(page, credentials);