Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usages of refs for React 19 compatibility #29536

Merged
merged 5 commits into from
Mar 28, 2025
Merged

Update usages of refs for React 19 compatibility #29536

merged 5 commits into from
Mar 28, 2025

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 18, 2025 •
edited
Loading

Split out from #28914

Needs patch-package unfortunately

The matrix-react-sdk-module-api changes are due to it being archived and lacking React 19 support
The react types changes are to allow us to make changes to use types closer to React 19 before we update, to make the update itself more palatable

@t3chguy t3chguy added the T-Task Tasks for the team like planning label Mar 18, 2025
@t3chguy t3chguy self-assigned this Mar 18, 2025
t3chguy added 2 commits March 27, 2025 12:35
@t3chguy
Merge branch 'develop' of https://github.com/vector-im/element-web in…
d55d66e 
…to t3chguy/react19/refs

# Conflicts:
#	src/components/views/elements/AppTile.tsx
#	src/components/views/elements/PersistentApp.tsx
#	src/components/views/messages/CodeBlock.tsx
#	src/components/views/rooms/wysiwyg_composer/EditWysiwygComposer.tsx
#	src/components/views/rooms/wysiwyg_composer/SendWysiwygComposer.tsx
#	src/components/views/rooms/wysiwyg_composer/components/PlainTextComposer.tsx
@t3chguy
Iterate
dd54f7b 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Iterate
19f7aab 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Simplify
7121498 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy marked this pull request as ready for review March 27, 2025 13:40
@t3chguy t3chguy requested review from a team as code owners March 27, 2025 13:40
uhoreg
uhoreg approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like just type and formatting changes in the crypto-related code, so lgtm from a crypto perspective.

dbkr
dbkr approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame about having to patch our own package but it seems sort of better than digging react-sdk-module-api out of its grave, especially sicne we need to patch the react types temporarily.

@t3chguy t3chguy added this pull request to the merge queue Mar 28, 2025
Merged via the queue into develop with commit fac9828 Mar 28, 2025
44 checks passed
@t3chguy t3chguy deleted the t3chguy/react19/refs branch March 28, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@uhoreg uhoreg uhoreg approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-team

Assignees

@t3chguy t3chguy

Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t3chguy @dbkr @uhoreg