Allow sticker picker to be resized#32467
Open
art0007i wants to merge 4 commits intoelement-hq:developfrom
Open
Allow sticker picker to be resized#32467art0007i wants to merge 4 commits intoelement-hq:developfrom
art0007i wants to merge 4 commits intoelement-hq:developfrom
Conversation
Member
|
Some screenshots would help design to review this. Note that this will also need tests, but you may want to wait for design's input first. |
Author
|
Here's a short video of what this PR currently looks like. Basically it's just an invisible square that you can drag around to resize. sticker.mp4For tests I'm not too experienced with writing them, so I'm not sure what I should even test, especially because the PR is a pretty small change. |
Member
|
@art0007i https://sonarcloud.io/component_measures?metric=new_coverage&selected=element-web%3Asrc%2Fcomponents%2Fviews%2Frooms%2FStickerpicker.tsx&view=list&pullRequest=32467&id=element-web will show you which lines of source code are uncovered and need test coverage. The minimum bar for a PR to land is 80% coverage of new code |
t3chguy
reviewed
Feb 13, 2026
8f7bc3a to
31778f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #18929
As said in the issue the default size of the sticker picker is too small, so I added a handle which allows resizing it.
To use this new option simply click and drag the top left corner of the sticker picker. It also stores the desired size in local storage to persist between application reloads.
Checklist
public/exportedsymbols have accurate TSDoc documentation.