No need to have version_string as an argument since it's always the same
#19012
+23
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keywords make it easier to search and positional arguments are easy to mess up especially when there are multiple strings next to each other.
MadLittleMods
commented
Oct 3, 2025
| version_string: A string to present for the Server header | ||
| max_request_body_size: TODO | ||
| context_factory: TODO | ||
| reactor: TODO |
There was a problem hiding this comment.
These are future TODO's (not for this PR)
MadLittleMods
commented
Oct 3, 2025
|
|
||
| def __init__( | ||
| self, | ||
| *, |
There was a problem hiding this comment.
Made these keyword only arguments to make it easier to search and confirm what server_version_string was used for.
Additionally, a good idea because positional arguments are easy to mess up especially when there are multiple strings next to each other.
MadLittleMods
commented
Oct 3, 2025
| self._instance_name = config.worker.instance_name | ||
|
|
||
| self.version_string = version_string | ||
| self.version_string = f"Synapse/{SYNAPSE_VERSION}" |
There was a problem hiding this comment.
The main change is consolidating everything to this assignment instead of this being passed in as an argument.
Conflicts: synapse/app/homeserver.py
anoadragon453
approved these changes
Oct 7, 2025
|
Thanks for the review @anoadragon453 🦝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to have
version_stringas an argument since it's always the same.Assuming, we're happy with #19011, this PR makes sense. But we should leave the decision and context of having them be the same to that PR first.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.