Add more validation and logging to policy server signature responses.#19807
Draft
reivilibre wants to merge 8 commits into
Draft
Add more validation and logging to policy server signature responses.#19807reivilibre wants to merge 8 commits into
reivilibre wants to merge 8 commits into
Conversation
d333007 to
bc4538e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was working on this to fix #19796 but didn't notice that #19797 was already opened to fix it.
Have now merged in develop to build on top.
Notable changes:
(It didn't sit right with me to overwrite an existing signature)
Review guidance: Commit-by-commit review is generally fine, just beware that 'Validate policy server response.....' is partially conflicting with concurrent work on develop and the merge conflict resolves the difference. It may be easier to review that alongside the merge commit at the same time?
Original commit schedule, with full messages:
Promote InvalidResponseError to a 'real' error type
pydantic_models: Fix broken link, add RootModel equivalent
federation_client: Add Pydantic validation machinery
Validate policy server response and prevent overwriting signatures
Merge branch 'develop' into rei/fix_ps_signature_overwrite
Add a log for the case when the policy server tries to overwrite