Skip to content

Forbid changing display name in local rooms if enable_set_displayname is disabled.#19811

Open
bxdxnn wants to merge 4 commits into
element-hq:developfrom
bxdxnn:develop
Open

Forbid changing display name in local rooms if enable_set_displayname is disabled.#19811
bxdxnn wants to merge 4 commits into
element-hq:developfrom
bxdxnn:develop

Conversation

@bxdxnn

@bxdxnn bxdxnn commented May 29, 2026

Copy link
Copy Markdown

Forbid changing display name in local rooms if enable_set_displayname is disabled

Fixes #17048

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@bxdxnn bxdxnn requested a review from a team as a code owner May 29, 2026 17:03
@MadLittleMods MadLittleMods changed the title Forbid changing display name in local rooms if `enable_set_displaynam… Forbid changing display name in local rooms if enable_set_displayname is disabled May 29, 2026
@bxdxnn bxdxnn changed the title Forbid changing display name in local rooms if enable_set_displayname is disabled Forbid changing display name in local rooms if enable_set_displayname is disabled. Jun 1, 2026

@anoadragon453 anoadragon453 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

Could you add a changelog entry and run the linting please?

Comment thread synapse/handlers/room_member.py Outdated
Comment thread synapse/handlers/room_member.py Outdated
Comment thread synapse/handlers/room_member.py Outdated
bxdxnn and others added 3 commits June 23, 2026 19:39
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"enable_set_displayname: false" still allows users to change their local room display name

3 participants