Fix/presence user syncing nonblocking#19885
Open
shcherbak wants to merge 8 commits into
Open
Conversation
…sync user_syncing() was awaiting set_state() before returning the context manager, causing every /sync request to block on presence I/O (DB read/write on the presence writer, or an HTTP RPC from workers). Move the counter increment and mark_as_coming_online ahead of the call, then fire set_state via run_in_background consistent with how _end() is already handled.
…sync user_syncing() was awaiting set_state() before returning the context manager, causing every /sync request to block on presence I/O (DB read/write on the presence writer, or an HTTP RPC from workers). Move the counter increment and mark_as_coming_online ahead of the call, then fire set_state via run_in_background consistent with how _end() is already handled.
…sync user_syncing() was awaiting set_state() before returning the context manager, causing every /sync request to block on presence I/O (DB read/write on the presence writer, or an HTTP RPC from workers). Move the counter increment and mark_as_coming_online ahead of the call, then fire set_state via run_in_background consistent with how _end() is already handled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
presence: run set_state in background during user_syncing to unblock sync
user_syncing() was awaiting set_state() before returning the context
manager, causing every /sync request to block on presence I/O (DB
read/write on the presence writer, or an HTTP RPC from workers). Move
the counter increment and mark_as_coming_online ahead of the call, then
fire set_state via run_in_background consistent with how _end() is
already handled.