Skip to content

Comments

Remove notify_failures from test-all-warehouses.yml#924

Merged
haritamar merged 1 commit intomasterfrom
devin/1770668788-remove-notify-failures
Feb 10, 2026
Merged

Remove notify_failures from test-all-warehouses.yml#924
haritamar merged 1 commit intomasterfrom
devin/1770668788-remove-notify-failures

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Feb 9, 2026

Summary

Removes the notify_failures job from test-all-warehouses.yml. This Slack notification job is not needed and was creating irrelevant failures.

Note: the removed job's condition checked for contains(github.event_name, 'schedule'), but this workflow has no schedule trigger, so it was effectively dead code.

Review & Testing Checklist for Human

  • Confirm no other workflows depend on the notify_failures job in this file (e.g., via needs)

Notes

Requested by: @haritamar
Link to Devin run

Summary by CodeRabbit

  • Chores
    • Updated test workflow configuration to remove automatic failure notifications during scheduled test runs.

Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

👋 @devin-ai-integration[bot]
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.

@coderabbitai
Copy link

coderabbitai bot commented Feb 9, 2026

📝 Walkthrough

Walkthrough

Removed the notify_failures job from the GitHub Actions workflow that tests across all data warehouses. This eliminates a Slack notification step that previously alerted on test failures under specific scheduling conditions, along with its conditional gating logic.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/test-all-warehouses.yml
Removed the notify_failures job that triggered Slack notifications on test failures, including conditional gating logic and the reusable workflow dependency on notify_slack.yml.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A silence falls where alerts once chimed,
No more the Slack flood, no frantic time,
The tests still run, the workflow clean,
Simpler now, serene, serene!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: removing the notify_failures job from the test-all-warehouses workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devin/1770668788-remove-notify-failures

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@haritamar haritamar merged commit 5dd2198 into master Feb 10, 2026
17 of 23 checks passed
@haritamar haritamar deleted the devin/1770668788-remove-notify-failures branch February 10, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants