Remove notify_failures from test-all-warehouses.yml#924
Conversation
Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
👋 @devin-ai-integration[bot] |
📝 WalkthroughWalkthroughRemoved the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
Summary
Removes the
notify_failuresjob fromtest-all-warehouses.yml. This Slack notification job is not needed and was creating irrelevant failures.Note: the removed job's condition checked for
contains(github.event_name, 'schedule'), but this workflow has noscheduletrigger, so it was effectively dead code.Review & Testing Checklist for Human
notify_failuresjob in this file (e.g., vianeeds)Notes
Requested by: @haritamar
Link to Devin run
Summary by CodeRabbit