Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer existing app from GitHub RDNN to own domain #294

Merged
merged 6 commits into from
Sep 25, 2022
Merged

Transfer existing app from GitHub RDNN to own domain #294

merged 6 commits into from
Sep 25, 2022
+6 −2

Conversation

meisenzahl
Copy link
Member

Closes #293

@meisenzahl meisenzahl mentioned this pull request Jan 9, 2022
Closed
@danirabbit danirabbit requested a review from btkostner January 24, 2022 19:42
btkostner
btkostner reviewed Jan 24, 2022
View reviewed changes
Copy link
Contributor

@btkostner btkostner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to upgrade elementary/action-appcenter-review-parse to elementary/[email protected].

Also, not really a big thing, but you shouldn't need to add those inputs to review.yml because they are not used.

@meisenzahl meisenzahl requested a review from btkostner January 25, 2022 06:54
btkostner
btkostner approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@btkostner btkostner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

@danirabbit danirabbit marked this pull request as ready for review September 25, 2022 15:05
@danirabbit danirabbit enabled auto-merge (squash) September 25, 2022 15:05
@danirabbit danirabbit disabled auto-merge September 25, 2022 15:09
@danirabbit danirabbit merged commit 8e50301 into elementary:main Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btkostner btkostner btkostner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transfer existing app from GitHub RDNN to own domain
3 participants
@meisenzahl @btkostner @danirabbit