-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A submission for review application: Create io.github.codes-by-chetan… #546
base: main
Are you sure you want to change the base?
Conversation
….bluetooth-media-controller.json A submission for review my application bluetooth media controller. which is basically an app to control bluetooth media playback coming from an android device via bluetooth to linux devices requires
aren't there anyone who can review my submission?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for your app submission and we're sorry for late review. Here are some points you need to resolve:
- Your app name must be a unique instead of a generic one
Bluetooth Media Controller
. See also: https://docs.elementary.io/develop/appcenter/publishing-requirements#naming - You must not hardcode the path to the executable and icon in the desktop file. These paths would differ depends on the value passed to the
prefix
option of meson. - You need to package your app with Flatpak. Apps packaged with Debian packaging are no longer accepted. See also: https://docs.elementary.io/develop/appcenter/publishing-requirements#packaging
- Your .appdata.xml file must include:
- at least one screenshot of your app
-
developer
tag instead of deprecateddeveloper_name
tag - See also: https://docs.elementary.io/develop/appcenter/publishing-requirements#metainfo-and-oars
The followings are not requirements:
- We recommend you to use
io.github
prefix instead ofcom.github
prefix for the RDNNcom.github.chetanmohite.bluetooth-media-controller
.- Because Flathub no longer accept apps with the
com.github
prefix as written in their requirement. - We don't force this but you would get into trouble when you want to publish your app later on Flathub too.
- Because Flathub no longer accept apps with the
BTW I think the review checklist is meant to be filled by reviewers; it's not a checklist for app authors.
Oh I'm really sorry for that checklist, I'm new here i didn't knew about that earlier & thanks for clarifying the requirements this is my first app submission so i already expected a lot of changes. I will make these changes and then I'll request a review again. Thank you so much for reviewing my application @ryonakano. |
Don't be sorry, I think the checklist is confusing because it looks like as if authors need to fill it so that their app is accepted. 💦 I'm happy that you're submitting your app to our AppCenter. If you have some questions what you should do for the requested changes, you can ask for me here. Happy coding! |
@ryonakano Thanks , I will definitely ping you if i need some help. |
@ryonakano I have made the requested changes can you please review them |
…o.github.codes-by-chetan.bluedia.json
hi @alainm23 are you also from the app center review team |
hii @ryonakano i have updated and added the flathub manifest file because the build was failed can you please review and merge it again |
How did you decide these dependencies? (e.g. references links, name of generators if you used some, etc.) |
I have used those modules in my bluedia.py python script so I added them as dependencies is this a wrong a way ? |
I tried to generate the dependencies using flatpak-pip-generator as written in the Flatpak documentation, but its result didn't include pillow, so I wondered if there is any reason you included it in your manifest. I'm not familiar with Python so I might be wrong, please ignore if it's intentional 🙇
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other points I'm concerning are:
- You're using
io.github.codes.by.chetan.bluedia
as RDNN but you may want to useio.github.codes_by_chetan.bluedia
instead. I think the current one is hard to see and not common. - Your Flatpak manifest uses the GNOME runtime and SDK, but you need to use the elementary one instead to submit to AppCenter as written here.
- You're trying to grant access to
/
,/dev
,/bin
, /usr`, but is there any reason for this?
@ryonakano i will change those other things and i also think that pillow isn't a dependency so i will also remove it and the access for |
If you publish as flatpak, you would want to use portals to interact with bluetooth interfaces instead of asking broad system permissions and pretty much defeating the point of a sandboxing format You can test on your side what works or not, but here isnt the place for this |
….bluetooth-media-controller.json
A submission for review my application bluetooth media controller. which is basically an app to control bluetooth media playback coming from an android device via bluetooth to linux devices requires
Bluetooth Media Controller
A Python tool to control Bluetooth audio devices and display the currently playing track with playback controls. It uses
bluetoothctl
to manage Bluetooth connections and interacts with the audio devices.Features
Prerequisites
Before installing and using this tool, ensure that you have the following prerequisites:
Post-Installation Steps
After installation, you can run the Bluetooth Media Controller using the following command:
If the command is not found, you may need to log out and log back in or restart your system for the PATH to update.
Usage
As a linux user, you know that if you connect your phone to the computer via bluetooth, it starts sending audio to your computer and you can play media of your phone using your computer's speakers. But you can not control the media playback from your computer. This application is designed to solve this problem.
Once the tool is installed and running, you can use it to control Bluetooth devices.
Review Checklist
AppData
Flatpak