Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SymbolPane: Always scroll view when symbol item clicked #1504

Merged
merged 5 commits into from
Mar 8, 2025
Merged

SymbolPane: Always scroll view when symbol item clicked #1504

merged 5 commits into from
Mar 8, 2025

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jan 8, 2025

Fixes #1317

@jeremypw jeremypw added the Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix. label Jan 24, 2025
@jeremypw jeremypw requested a review from a team February 8, 2025 18:23
danirabbit
danirabbit approved these changes Mar 8, 2025
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess in an ideal world we should update the selected value as you scroll, but this makes sense to fix the issue as simply as possible 👍

@danirabbit danirabbit enabled auto-merge (squash) March 8, 2025 02:01
@danirabbit danirabbit merged commit 6095df3 into master Mar 8, 2025
6 checks passed
@danirabbit danirabbit deleted the jeremypw/symbol-pane-scroll-doc-on-click branch March 8, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symbol Pane: Does not scroll back to already selected method
2 participants
@jeremypw @danirabbit