Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Open in" submenu when running as Flatpak #1512

Merged
merged 3 commits into from
Mar 7, 2025
Merged

Fix "Open in" submenu when running as Flatpak #1512

merged 3 commits into from
Mar 7, 2025

Conversation

jeremypw
Copy link
Collaborator

Fixes #1511

zeebok
zeebok approved these changes Mar 2, 2025
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really wish we could say what app it would open in, and I am guessing we have no way to find that out, so this works well!

@zeebok
Copy link
Contributor

zeebok commented Mar 2, 2025

Just gotta fix the conflict

@jeremypw
Copy link
Collaborator Author

jeremypw commented Mar 3, 2025

@zeebok Thanks for the review! Yes, it would be better get the default app name if possible but I could not see how to do it in a distro-agnostic way and without perforating the sandbox. There doesn't seem to be a portal for this information. If I've missed something it can be improved later.

@zeebok zeebok merged commit 5afc26a into master Mar 7, 2025
6 checks passed
@zeebok zeebok deleted the jeremypw/flatpak/fix-open-in-menu branch March 7, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open in menu empty when running as Flatpak
2 participants
@jeremypw @zeebok