Rework word completion: Start to prepare PrefixNode for dynamic updating #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jeremypw
commented
Feb 1, 2025
jeremypw
commented
- Add a property counting how many times a word occurs in a document (used to remove nodes with zero occurrences)
- Distinguish node types: ROOT, CHAR, WORD_END. (WORD_END type carries occurrences property)
- Make tree bi-directional (nodes have parent property)
- Use Gee.ArrayList instead of GLib.List
danirabbit
reviewed
Feb 1, 2025
|
Reviewed scope and construction of properties. Type and character made immutable properties; occurrence count made private member. |
danirabbit
requested changes
Feb 2, 2025
danirabbit
approved these changes
Feb 6, 2025
danirabbit
deleted the
jeremypw/rework-word-completion/prep-add-remove-node
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.