Smooth switch between dark and light styles #354
Conversation
Just a suggestion :) The dock adapts in a smooth manner when changing style in system settings: slowly gets darker if switch to dark, slowly gets lighter if switch to light the animation follows the same as wingpanel becoming opaque - and as in several places in the stylesheet the animation is slower than wingpanel - as that one is too short and like current behaviour: immediate blink. I would go with slower here because the user is being eased in to the new colour - It is not the same context and intent as the interface adapting to a change
|
i summon @elementary/desktop-developers ! |
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| dock { | |||
| background: @bg_color; | |||
| transition: background 800ms cubic-bezier(0.4, 0, 0.2, 1); | |||
There was a problem hiding this comment.
Probably should also transition box-shadow
There was a problem hiding this comment.
same effect ?
how is the duration for you ?
i would like to suggest the same transition for the rest of eOS stylesheet, but i yet am not sure yet how to target the components efficiently so as to avoid having the transitions at any other time than when switching style
in a later PR probably.
There was a problem hiding this comment.
I don't mind the duration, but yes it needs the same transition on the box-shadow otherwise the shadow and highlight pops in while the background is animated.
Alice is more knowledgeable about this, since I think she did some stuff in GNOME/Adwaita for this. I think there was some kind of compositor-side transition but maybe it's in Adwaita these days. She would know
There was a problem hiding this comment.
Yes. She was the one who actually worked on this. But im not sure how to ask her
Just a suggestion :)
The dock adapts in a smooth manner when changing style in system settings: slowly gets darker if switch to dark, slowly gets lighter if switch to light the animation follows the same as wingpanel becoming opaque - and as in several places in the stylesheet
the animation is slower than wingpanel - as that one is too short and like current behaviour: immediate blink. I would go with slower here because the user is being eased in to the new colour - It is not the same context and intent as the interface adapting to a change