Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DwellClickTimer: Remove delay #2273

Closed
wants to merge 4 commits into from

Conversation

lenemter
Copy link
Member

No description provided.

@lenemter lenemter requested a review from a team February 16, 2025 11:55
@leolost2605 leolost2605 requested a review from a team March 2, 2025 13:59
@lenemter
Copy link
Member Author

lenemter commented Mar 8, 2025

@leolost2605 I removed delay because it is not needed anymore. I have no idea where it came from since mutter is responsible for dwell click, not libinput. Also gnome-shell doesn't add any delay either, so I don't think UX input is needed here

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lenemter ok yeah I just wasn't sure because I don't use this feature but the change was quite noticeably so I thought there must've been a reason for it.
Anyways the changes LGTM :)

@davidmhewitt
Copy link
Member

#1152

@lenemter
Copy link
Member Author

lenemter commented Mar 9, 2025

@davidmhewitt Thanks for linking that, I totally missed this issue

@lenemter lenemter closed this Mar 9, 2025
@lenemter lenemter deleted the lenemter/dwellclicktimer-remove-timmeout branch March 9, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants