Skip to content

Remove navigation#14

Merged
jo-elimu merged 3 commits intoelimu-ai:mainfrom
decoolesabri:remove-navigation
Jun 19, 2025
Merged

Remove navigation#14
jo-elimu merged 3 commits intoelimu-ai:mainfrom
decoolesabri:remove-navigation

Conversation

@decoolesabri
Copy link
Copy Markdown

@decoolesabri decoolesabri commented Jun 19, 2025

Issue Number

Purpose

  • To free up screen space for the educational content.
  • To make the game fragment the first fragment to appear.

Technical Details

  • No

Screenshots

  • Before:
    Schermafbeelding 2025-06-19 112321
    Schermafbeelding 2025-06-19 112336
    Schermafbeelding 2025-06-19 112356
    Schermafbeelding 2025-06-19 112414

  • After:
    Schermafbeelding 2025-06-19 111929
    Schermafbeelding 2025-06-19 111945
    Schermafbeelding 2025-06-19 112003
    Schermafbeelding 2025-06-19 112018

Testing Instructions

  • 1: Run the app
  • 2: Check how the navigation menu has been deleted
  • 3: Check how the different layout items are scaled and placed right now
  • 4: Repeat the steps with landscape layout

Regression Tests

  • I tested my changes on Android 16 (API 36)
  • I tested my changes on Android 15 (API 35)
  • I tested my changes on Android 14 (API 34)
  • I tested my changes on Android 13 (API 33)
  • I tested my changes on Android 12L (API 32)
  • I tested my changes on Android 12 (API 31)
  • I tested my changes on Android 11 (API 30)
  • I tested my changes on Android 10 (API 29)
  • I tested my changes on Android 9 (API 28)
  • I tested my changes on Android 8.1 (API 27)
  • I tested my changes on Android 8.0 (API 26)

I tested some and nothing is broken.

UI Tests

  • I tested my changes on a 6-7" screen (▯ portrait orientation)
  • I tested my changes on a 6-7" screen (▭ landscape orientation)
  • I tested my changes on a 7-8" screen (▯ portrait orientation)
  • I tested my changes on a 7-8" screen (▭ landscape orientation)
  • I tested my changes on a 9-10" screen (▯ portrait orientation)
  • I tested my changes on a 9-10" screen (▭ landscape orientation)

Content Tests

  • I tested my changes with English content (eng.elimu.ai)
  • I tested my changes with Hindi content (hin.elimu.ai)
  • I tested my changes with Tagalog content (tgl.elimu.ai)
  • I tested my changes with Thai content (tha.elimu.ai)
  • I tested my changes with Vietnamese content (vie.elimu.ai)

No problems here.

Summary by CodeRabbit

  • New Features

    • The initial screen displayed upon app launch has changed from the home screen to the plant screen.
  • Refactor

    • The BottomNavigationView has been removed from both portrait and landscape layouts, streamlining the navigation experience.
    • Adjusted layout and spacing of key UI containers and animations in the landscape game screen for improved visual alignment.

I removed the navigation bar and corrected some layout elements so it looks better without the bar. I also set the start layout on plant (so the game is the first thing that starts after opening the app).
I moved the play button and succes animation down a bit in the landscape layout so it is more centered.
@decoolesabri decoolesabri requested a review from a team as a code owner June 19, 2025 09:27
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 19, 2025

Walkthrough

The BottomNavigationView has been removed from both portrait and landscape main activity layouts. All related initialization and setup code in MainActivity has been disabled. The navigation graph's start destination now points to the "plant" fragment instead of "home." Additional layout adjustments were made to landscape game fragments.

Changes

File(s) Change Summary
app/src/main/java/ai/elimu/learndigits/MainActivity.kt Disabled BottomNavigationView initialization and setup by removing related code lines.
app/src/main/res/layout/activity_main.xml
app/src/main/res/layout-land/activity_main.xml
Removed BottomNavigationView from both portrait and landscape main activity layouts.
app/src/main/res/layout-land/fragment_game.xml Adjusted layout constraints, margins, and vertical biases for containers and animations.
app/src/main/res/navigation/mobile_navigation.xml Changed navigation graph start destination from "home" to "plant" fragment.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MainActivity
    participant NavController
    participant Fragment (Plant)

    User->>MainActivity: Launch app
    MainActivity->>NavController: Initialize navigation (no BottomNavigationView)
    NavController->>Fragment (Plant): Set start destination to Plant fragment
    Fragment (Plant)-->>User: Display Plant fragment content
Loading

Assessment against linked issues

Objective Addressed Explanation
Remove the navigation menu from the bottom of the screen (#12)

Assessment against linked issues: Out-of-scope changes

Code Change Explanation
Layout constraint and bias adjustments in fragment_game.xml (app/src/main/res/layout-land/fragment_game.xml) These layout refinements are not directly mentioned in the objective of removing the bottom navigation menu. Their relevance to the stated issue is unclear.

Possibly related PRs

  • Feature/landscape #10: Adds landscape layout files with BottomNavigationView and landscape orientation; this PR directly removes or disables those UI elements, making them closely related.

Suggested reviewers

  • jo-elimu

elimu.ai's mission is to build innovative learning software that empowers out-of-school children to teach themselves basic reading📖, writing✍🏽 and math🔢 within 6 months.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a31eb03 and 70f948a.

📒 Files selected for processing (1)
  • app/src/main/java/ai/elimu/learndigits/MainActivity.kt (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/src/main/java/ai/elimu/learndigits/MainActivity.kt
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: build (ubuntu-latest, 17)
  • GitHub Check: build (windows-latest, 17)
  • GitHub Check: build (macos-latest, 21)
  • GitHub Check: build (ubuntu-latest, 21)
  • GitHub Check: build (windows-latest, 21)
  • GitHub Check: build (macos-latest, 17)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Removed some comments.
@jo-elimu jo-elimu requested a review from tuancoltech June 19, 2025 09:53
@jo-elimu jo-elimu merged commit 3dee3b4 into elimu-ai:main Jun 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the navigation menu from the bottom of the screen

2 participants