Draft: Added InputUriError and IPDistanceCalculationError

[Nidhi091999]

Issue: #168

Summary by Sourcery

Add InputUriError and IPDistanceCalculationError exceptions, and add a TesUriError exception.

New Features:

• Added InputUriError for signaling invalid input URIs.
• Added IPDistanceCalculationError for when IP distance calculation fails.
• Added TesUriError for when a TES URI cannot be parsed.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces three new exception classes: InputUriError, IPDistanceCalculationError, and TesUriError. These exceptions are added to the pro_tes/exceptions.py file and are also included in the exceptions dictionary.

Class diagram showing new exception hierarchy

classDiagram
    ValueError <|-- TesUriError
    ValueError <|-- InputUriError
    ValueError <|-- IPDistanceCalculationError
    ValueError <|-- MiddlewareException
    MiddlewareException <|-- InvalidMiddleware

    class TesUriError {
      +str message
      +str code
    }
    note for TesUriError "New: Raised when TES URI cannot be parsed"

    class InputUriError {
      +str message
      +str code
    }
    note for InputUriError "New: Raised when input URI cannot be parsed"

    class IPDistanceCalculationError {
      +str message
    }
    note for IPDistanceCalculationError "New: Raised when IP distance cannot be calculated"

    class MiddlewareException {
      +str message
      +str code
    }

    class InvalidMiddleware {
      +str message
      +str code
    }

Loading

File-Level Changes

Change	Details	Files
Added InputUriError exception class.	Added InputUriError class inheriting from ValueError. Added InputUriError to the exceptions dictionary with a message and code.	pro_tes/exceptions.py
Added IPDistanceCalculationError exception class.	Added IPDistanceCalculationError class inheriting from ValueError. Added IPDistanceCalculationError to the exceptions dictionary with a message.	pro_tes/exceptions.py
Added TesUriError exception class.	Added TesUriError class inheriting from ValueError. Added TesUriError to the exceptions dictionary with a message.	pro_tes/exceptions.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @Nidhi091999 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please fill out the PR description with details about the motivation for these new exceptions and reference any related issues.
• The exceptions dictionary entries should maintain consistency - TesUriError and IPDistanceCalculationError are missing HTTP status codes while other entries have them.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue: Missing error code for TesUriError and IPDistanceCalculationError exceptions

Other exceptions in the dictionary include both 'message' and 'code' fields. Consider adding appropriate error codes to maintain consistency in error handling.