Fix crash on error detail page when using MySQL/MariaDB #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phihos
force-pushed
the
fix-bug-150
branch
9 times, most recently
from
bc070c2 to
b6b143c
Compare
|
Ok, done refactoring now. Tests pass and code looks good to me at least. |
Instead of using `{:array, :string}` for the `:breadcrumbs` field in `ErrorTracker.Occurrence` we use a new custom field type `ErrorTracker.Types.StringArray`.
It uses `Jason` to decode arrays when retrieving data from MySQL/MariaDB. Therefore it works very similarly to the `:array` type but without crashing on retrieval.
This fix does not make a schema migration necessary. An additional test module `ErrorTracker.StoreFetchTest` was implemented to avoid regreessions in the future.
Fixes elixir-error-tracker#150.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
{:array, :string}for the:breadcrumbsfield inErrorTracker.Occurrencewe use a new custom field typeErrorTracker.Types.StringArray.It uses
Jasonto decode arrays when retrieving data from MySQL/MariaDB. Therefore it works very similarly to the:arraytype but without crashing on retrieval.This fix does not make a schema migration necessary. An additional test module
ErrorTracker.StoreFetchTestwas implemented to avoid regreessions in the future.Fixes #150.