Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we want to let Samples inherit Source material info to comply with the ENA minimal checklist? (collection date and geografical location) #81

Open
bedroesb opened this issue Nov 8, 2024 · 0 comments

Comments

@bedroesb
Copy link
Member

bedroesb commented Nov 8, 2024

Collection data and Geographical location is currently added to the source material, and not to sample, but ENA will look into the registered Sample in BioSamples. This throws an error since these are mandatory fields for ENA. Currently the MARS ENA repository API fills in default values (Not provided) but we might want to think about inheriting these values from Source material instead
Original post:

The ISA-JSON we are using actually contains those fields. I think we might want to revert this for the source sample.

collection date:

"category": {
"@id": "#characteristic_category/collection_date_323"
},
"value": {
"annotationValue": "01/01/2022",
"termSource": "",
"termAccession": ""
}
},

Geographic location:

"category": {
"@id": "#characteristic_category/geographic_location_(country_and/or_sea)_326"
},
"value": {
"annotationValue": "Belgium",
"termSource": "",
"termAccession": ""
}
},

Originally posted by @kdp-cloud in #69 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant