Skip to content

Commit

Permalink
Add Plug.Router tests (#1234)
Browse files Browse the repository at this point in the history
* Add test that asserts an error is raised with the expected
  message when Plug.Router.match/3 is not given :to or :do option.

* Add test that asserts an error is raised with the expected
  message when no routes are defined in a Plug module.
  • Loading branch information
thymusvulgaris authored Jun 25, 2024
1 parent b9af901 commit 90590ab
Showing 1 changed file with 26 additions and 0 deletions.
26 changes: 26 additions & 0 deletions test/plug/router_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -614,6 +614,32 @@ defmodule Plug.RouterTest do
%{route: "/", conn: %Plug.Conn{}, router: Sample}}
end

test "error is raised with expected message when match/3 is not given :to or :do option" do
assert_raise ArgumentError, "expected one of :to or :do to be given as option", fn ->
defmodule NoExpectedMatchOptions do
use Plug.Router

plug :match
plug :dispatch

match "/", foo: :bar
end
end
end

test "error is raised with expected message when no routes are defined" do
assert_raise RuntimeError,
"no routes defined in module Plug.RouterTest.NoRoutes using Plug.Router",
fn ->
defmodule NoRoutes do
use Plug.Router

plug :match
plug :dispatch
end
end
end

defp attach(handler_id, event) do
:telemetry.attach(
handler_id,
Expand Down

0 comments on commit 90590ab

Please sign in to comment.