Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plug Debugger add ability to wrap exception text #1241

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

axelson
Copy link
Contributor

@axelson axelson commented Aug 24, 2024

Sometimes exceptions print out with really long lines which makes it difficult to read the exceptions on the error page:

Screenshot.2024-08-24.08-20-12-converted.mp4

This PR wraps the text and decreases the font size so more can be read without scrolling:
Screenshot 2024-08-26 08-26-46@2x

previous implementation This PR adds a "Wrap text?" checkbox that toggles wrapping on the exception details:
Screenshot.2024-08-24.08-05-22-converted.mp4

It also decreases the font size slightly so that it is easier to read the details

Alternatively we may want to only change the CSS to always wrap and also decrease the font-size. Or maybe keep the checkbox but default it to on.

Sometimes exceptions print out with really long lines which makes it
difficult to read the exceptions on the error page.

This PR adds a "Wrap text?" checkbox that toggles wrapping on the
exception details.
@whatyouhide
Copy link
Member

Should we think about just always wrapping text instead?

@josevalim
Copy link
Member

Yes, let's wrap by default and decrease the font size. 👍

@axelson
Copy link
Contributor Author

axelson commented Aug 26, 2024

Okay, updated!

@josevalim josevalim merged commit 9037502 into elixir-plug:main Aug 26, 2024
2 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@axelson axelson deleted the plug-debugger-wrap-text branch August 30, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants