link Module.function/arity to hexdocs in exception messages
#1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Idea by @Gazler This is similar to ExDoc autolinking, but only works for the simple Elixir `Module.function/arity` format.
|
Note that this requires a change in LiveView to actually emit that warning: diff --git a/lib/phoenix_live_view/live_stream.ex b/lib/phoenix_live_view/live_stream.ex
index a88bef15..a445c56f 100644
--- a/lib/phoenix_live_view/live_stream.ex
+++ b/lib/phoenix_live_view/live_stream.ex
@@ -44,7 +44,7 @@ defmodule Phoenix.LiveView.LiveStream do
raise ArgumentError, """
expected stream :#{dom_prefix} to be a struct or map with :id key, got: #{inspect(other)}
- If you would like to generate custom DOM id's based on other keys, use stream_configure/3 with the :dom_id option beforehand.
+ If you would like to generate custom DOM id's based on other keys, use `Phoenix.LiveView.stream_configure/3` with the :dom_id option beforehand.
"""
end |
josevalim
reviewed
Feb 27, 2025
josevalim
reviewed
Feb 27, 2025
lib/plug/debugger.ex
Outdated
| defp maybe_format_function_reference(text), do: h(text) | ||
|
|
||
| defp function_reference?(text) do | ||
| Regex.match?(~r/^[A-Z][A-Za-z0-9_.]+\.[a-z][A-Za-z0-9_!?]*\/\d+$/, text) |
There was a problem hiding this comment.
We should probably merge this regex into the previous one, so we only parse ... that already match this form?
josevalim
reviewed
Feb 27, 2025
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea by @Gazler
This is similar to ExDoc autolinking, but only works for the simple Elixir
Module.function/arityformat.Before:
After:
