You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Any anchor without href cannot be traversed with the keyboard.
This PR uses custom nuxt link and vue component for button when button attr configured: the Show intro "link" cannot be activated using the keyboard (maybe there is a shorcut)
Any anchor without href cannot be traversed with the keyboard.
This is actually the correct behavior in browsers:
Some focusable HTML elements have a default tabindex value of 0 set under the hood by the user agent. These elements are an or with href attribute, (...)
So maybe setting tabindex="0" or changing <a> to <button> can be a simpler way instead of handling focus event by JavaScript.
I also noticed that some <SettingsItem> are rendered as <a disabled="false" ...>. This false is an invalid value for the disabled property and has the same effect as disabled="true" (ref. Explicitly set disabled="false" in the HTML does not work - Stack Overflow - https://stackoverflow.com/questions/32745276/explicitly-set-disabled-false-in-the-html-does-not-work/32745315#32745315). This may affect the focusable property because the disabled element is skipped to be focused. I'm going to make a PR to fix this attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any anchor without href cannot be traversed with the keyboard.
This PR uses custom nuxt link and vue component for button when
buttonattr configured: theShow intro"link" cannot be activated using the keyboard (maybe there is a shorcut)