Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing props and files for Code Viewer, R Editor and Scala Editor extensions #3280

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

caponetto
Copy link
Contributor

What changes were proposed in this pull request?

I was reviewing the code and noticed that there was some stuff missing if you compare Code Viewer, R Editor and Scala Editor extensions with the others. So, I'm standardizing everything on this PR. I'm also removing ignorePatterns prop from .eslintrc.json, which doesn't make more sense.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@caponetto caponetto requested a review from lresende January 16, 2025 08:56
@lresende lresende merged commit d23c719 into elyra-ai:main Jan 18, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants