Skip to content

Bugfix flutter run #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Bugfix flutter run #225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19f7d5f
lsp-dart-run error fixed
lazyskulptor Apr 16, 2024
7b88321
lsp-dart-run error fix with using lsp-get on keys
jheld Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions lsp-dart-dap.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,18 +261,22 @@ Call CALLBACK when the device is chosen and started successfully."
(buffer-file-name))))))
(lambda (start-debugging-callback)
(lsp-dart-dap--flutter-get-or-start-device
(-lambda ((&hash "id" device-id "name" device-name))
(funcall start-debugging-callback
(-> pre-conf
(dap--put-if-absent :deviceId device-id)
(dap--put-if-absent :deviceName device-name)
(dap--put-if-absent :dap-server-path (if (lsp-dart-dap-use-sdk-debugger-p)
(append (lsp-dart-flutter-command) (list "debug_adapter" "-d" device-id))
lsp-dart-dap-flutter-debugger-program))
(dap--put-if-absent :flutterPlatform "default")
(dap--put-if-absent :toolArgs `("-d" ,device-id))
(dap--put-if-absent :name (concat "Flutter (" device-name ")")))))))))

(lambda (device-params)
(let ((device-id (lsp-get device-params :id))
(device-name (lsp-get device-params :name)))

(funcall start-debugging-callback
(-> pre-conf
(dap--put-if-absent :deviceId device-id)
(dap--put-if-absent :deviceName device-name)
(dap--put-if-absent :dap-server-path (if (lsp-dart-dap-use-sdk-debugger-p)
(append (lsp-dart-flutter-command) (list "debug_adapter" "-d" device-id))
lsp-dart-dap-flutter-debugger-program))
(dap--put-if-absent :flutterPlatform "default")
(dap--put-if-absent :toolArgs `("-d" ,device-id))
(dap--put-if-absent :name (concat "Flutter (" device-name ")"))))
))))))

(dap-register-debug-provider "flutter" 'lsp-dart-dap--populate-flutter-start-file-args)
(dap-register-debug-template "Flutter :: Debug"
(list :type "flutter"))
Expand Down
Loading