Rework regular conversion to allow use with external trigger and avoid reconfiguration for each sample #4786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d1ac54a.
…trigger for break input
…tput_idle_state to accept channel iterator as input
…mode_injected_sampling
…nfiguring of DMA and adc channels for each read
…g RingBuffer for regular conversions.
…le to use it as trigger source for ADC measurements
…ethod for more flexibility.
…ar_and_injected_adc
|
The first question I have is how the regular conversion differs from the readable ringbuffer that I have implemented. If injected conversions were not a factor, would that be sufficient? |
Yes, thanks for highlighting. It seems to cover my needs for the regular channels. I will scrap this PR and open a new one based on the RingBuffer module instead: #4840 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the changes in #4243 which introduces configuration of injected ADC measurements. This PR expands the ADC module for STM32 g4 processors to support both injected and regular ADC conversions.
read()method as it was for backwards compatibility