i2cv1 slave mode #4812
Merged
i2cv1 slave mode #4812
+1,360
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation during v1 rework" This reverts commit d38e1de962b92d1d48f1991ce09e494ea46d3f7f.
…te struct" This reverts commit b690a03.
|
@xoviat - Hi. Glad to see this merged! I noticed that my "cosmetic" changes were rejected. Most notably the renaming of the FrameOptions enum. Would you be open to accepting this change in a follow-up PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating the pr and reducing the diff
Closes #4579.