Fix configuration of embassy_rp adc div register #4815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
read_many_innerwill usewrite_setfor writing the adcdivregister. Thewrite_setmethod will by definition only set bits in the register but it will never clear bits. This can lead to an incorrect value (bitwise or of all values configured in the past) in thedivregister when switching between different values without fully resetting the ADC in between.Reproducer:
This will print
div=127instead of the expected valuediv=96.Please note that the
read_manyAPI does not support fractional dividers (and this cannot be changed without a breaking API change). In order to allow working around this restriction by manually setting the fractional part viapac::ADC(something which was already possible before this PR), this PR is usingr.div().modify(...)(and notr.div().write(...)) so that it won't touch a fractional part configured manually before.