Skip to content

Conversation

@plaes
Copy link
Contributor

@plaes plaes commented Nov 3, 2025

Firstly, fix code formatting inside docstring and then hopefully clarify the timer availability a bit more.

@lulf
Copy link
Member

lulf commented Nov 4, 2025

You should add the ignore attribute as well.

@plaes plaes force-pushed the stm32-pwm-docs-misc branch from fa41b6d to f440a3e Compare November 4, 2025 07:26
@plaes
Copy link
Contributor Author

plaes commented Nov 4, 2025

You should add the ignore attribute as well.

Thanks, added. Also updated the same note for waveform_up docstring.

Would it make sense to add a method that would automatically infer correct DMAx_CHy based on the used timer/channel? For example currently we do:

let mut foo = SimplePwm::new(d.TIM4, ...);
foo.waveform_up(dp.DMA1_CH7.reborrow(), pwm_channel, color).await;

Or can't we somehow infer the DMA instance and channel based on the timer and fill in the DMA1_CH7 automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants