Fix: Get cccd with FIND_INFORMATION instead of READ_BY_TYPE#350
Fix: Get cccd with FIND_INFORMATION instead of READ_BY_TYPE#350lulf merged 7 commits intoembassy-rs:mainfrom
Conversation
|
A couple notes: I changed get_characteristic_cccd() to no longer return the state of the CCCD from the server because it would require sending an additional message and the value wasn't actually being used anywhere. Happy to change that back though. I implemented an arm for encode() (copying the format of the ReadByType arm) because it was throwing an error otherwise. I don't understand what that method is for though. Both arms generate bytes from their associated iterators, which parse from bytes. So they end up converting from bytes into messages and then immediately back into those same bytes. If I'm understanding it correctly, attribute_server.rs is where the serialization occurs when response are being sent to clients. |
|
/test |
|
Could you rebase this PR on latest main? In order to run the integration tests locally, you need two nrf52840 dongles and/or devkits flashed with the zephyr uart controller. |
|
I fixed the merge conflicts. I also got local tests working, and found and fixed the bug that was leading to the test failure. They pass for me now. |
|
/test |
|
How is work going on this PR? I would love to use the find information functionality you have here. I had actually already forked and implemented the find information request/response and was thinking about submitting a PR, but then I saw this and the solution is pretty much identical. |
|
/test |
|
/test |
Fixes #346