Skip to content

profile options would not work for deploy:list #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

st-h
Copy link

@st-h st-h commented May 15, 2020

the profile option is not picked up when running deploy:list, as this config is never read and it seems like the profile option needs to be set before calling the S3 constructor (as it is done in the other ember-deploy-s3 plugins)

I additionally tried to add some log statements, however I was unable to use this.log. Even when passing it as a params to _list would show an error:

TypeError: Cannot read property 'logInfoColor' of undefined
TypeError: Cannot read property 'logInfoColor' of undefined
    at log (node_modules/ember-cli-deploy-plugin/index.js:76:34)

So, I went with console statements as I am unaware of the finer nodejs and ember-deploy details and I currently don't have any time to look into it. Will be happy to modify if someone can point me in the right direction.

@st-h
Copy link
Author

st-h commented May 1, 2021

Hey, just wanted to get back to this PR. Is there any issue, which prevents it from being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant