profile options would not work for deploy:list #10
+13
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
profile
option is not picked up when runningdeploy:list
, as this config is never read and it seems like the profile option needs to be set before calling the S3 constructor (as it is done in the other ember-deploy-s3 plugins)I additionally tried to add some log statements, however I was unable to use
this.log
. Even when passing it as a params to_list
would show an error:So, I went with
console
statements as I am unaware of the finer nodejs and ember-deploy details and I currently don't have any time to look into it. Will be happy to modify if someone can point me in the right direction.