Merge pull request #123 from CrowdStrike/optimise-deploy-with-overwrite

fix: Optimise upload when `allowOverwrite` is true

lib/s3.js

@@ -62,6 +62,7 @@ module.exports = CoreObject.extend({
     var isGzipped                 = gzippedFilePaths.indexOf(options.filePattern) !== -1;
     var isBrotliCompressed        = brotliCompressedFilePaths.indexOf(options.filePattern) !== -1;
     var serverSideEncryption      = options.serverSideEncryption;
+    var checkForOverwrite         = RSVP.resolve();
 
     var params = {
       Bucket: bucket,
@@ -83,13 +84,17 @@ module.exports = CoreObject.extend({
       params.ContentEncoding = 'br';
     }
 
-    return this.findRevision(options)
-      .then(function(found) {
-        if (found !== undefined && !allowOverwrite) {
-          return RSVP.reject("REVISION ALREADY UPLOADED! (set `allowOverwrite: true` if you want to support overwriting revisions)");
-        }
-        return RSVP.resolve();
-      })
+    if (!allowOverwrite) {
+      checkForOverwrite = this.findRevision(options)
+        .then(function(found) {
+          if (found !== undefined) {
+            return RSVP.reject("REVISION ALREADY UPLOADED! (set `allowOverwrite: true` if you want to support overwriting revisions)");
+          }
+          return RSVP.resolve();
+        })
+    }
+
+    return checkForOverwrite
       .then(readFile.bind(this, options.filePath))
       .then(function(fileContents) {
         params.Body = fileContents;