[Next] Kill ArrayProxy, ObjectProxy, and PromiseProxy #20918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development AssetsDiff --- main/out.txt 2025-06-10 16:53:24.000000000 +0000
+++ pr/./pr-15569792620/out.txt 2025-06-10 20:43:34.000000000 +0000
@@ -1,98 +1,98 @@
- 2.2M └─┬ .
-1014K ├─┬ @ember
- 205K │ ├─┬ -internals
- 69K │ │ ├─┬ views
- 64K │ │ │ └─┬ lib
- 23K │ │ │ ├── mixins
- 22K │ │ │ ├── system
- 10K │ │ │ ├── views
- 4.3K │ │ │ └── compat
- 35K │ │ ├─┬ runtime
- 30K │ │ │ └─┬ lib
- 21K │ │ │ ├── mixins
- 5.7K │ │ │ └── ext
- 26K │ │ ├─┬ meta
- 21K │ │ │ └── lib
- 11K │ │ ├── owner
- 9.4K │ │ ├── deprecations
- 7.4K │ │ ├── metal
- 7.0K │ │ ├── string
- 5.0K │ │ ├── glimmer
- 4.9K │ │ ├── utils
- 4.9K │ │ ├── routing
- 4.5K │ │ ├── error-handling
- 4.5K │ │ ├── utility-types
- 4.2K │ │ ├── container
- 4.2K │ │ ├── browser-environment
- 4.1K │ │ └── environment
- 183K │ ├─┬ routing
- 28K │ │ └── lib
- 149K │ ├─┬ object
- 66K │ │ └─┬ lib
- 62K │ │ └── computed
- 114K │ ├─┬ template-compiler
- 109K │ │ └─┬ lib
- 20K │ │ ├── plugins
- 4.6K │ │ ├── system
- 4.1K │ │ └── -internal
- 66K │ ├─┬ application
- 5.6K │ │ └── lib
- 52K │ ├─┬ debug
- 21K │ │ └── lib
- 38K │ ├─┬ array
- 4.9K │ │ └── lib
- 31K │ ├─┬ engine
- 4.7K │ │ └── lib
- 27K │ ├── runloop
- 22K │ ├─┬ utils
- 18K │ │ └── lib
- 20K │ ├── helper
- 11K │ ├── destroyable
- 9.8K │ ├── instrumentation
- 9.4K │ ├── controller
- 7.4K │ ├── service
- 7.2K │ ├── owner
- 6.2K │ ├── component
- 5.6K │ ├── canary-features
- 5.5K │ ├── modifier
- 5.1K │ ├── template-compilation
- 5.0K │ ├── enumerable
- 5.0K │ ├── test
- 4.4K │ ├── template
- 4.4K │ ├── renderer
- 4.2K │ ├── deprecated-features
- 4.1K │ ├── template-factory
- 4.1K │ └── version
- 708K ├── shared-chunks
- 384K ├─┬ @glimmer
- 166K │ ├── runtime
- 60K │ ├── opcode-compiler
- 30K │ ├── manager
- 22K │ ├── validator
- 14K │ ├── program
- 12K │ ├── reference
- 11K │ ├── destroyable
- 10K │ ├─┬ tracking
- 4.4K │ │ └── primitives
- 10K │ ├── util
- 8.1K │ ├── node
- 7.3K │ ├── global-context
- 6.4K │ ├── wire-format
- 5.0K │ ├── vm
- 4.9K │ ├── encoder
- 4.6K │ ├── owner
- 4.1K │ └── env
- 60K ├─┬ ember-testing
- 56K │ └─┬ lib
- 14K │ ├── test
- 14K │ ├── helpers
- 10K │ ├── ext
- 6.4K │ └── adapters
- 31K ├── backburner.js
- 25K ├── ember
- 24K ├── route-recognizer
- 18K ├─┬ @simple-dom
- 14K │ └── document
- 9.2K ├── dag-map
- 4.3K ├── rsvp
- 4.3K └── router_js
+2.2M └─┬ .
+989K ├─┬ @ember
+201K │ ├─┬ -internals
+ 68K │ │ ├─┬ views
+ 63K │ │ │ └─┬ lib
+ 23K │ │ │ ├── mixins
+ 22K │ │ │ ├── system
+9.5K │ │ │ ├── views
+4.3K │ │ │ └── compat
+ 31K │ │ ├─┬ runtime
+ 27K │ │ │ └─┬ lib
+ 17K │ │ │ ├── mixins
+5.7K │ │ │ └── ext
+ 26K │ │ ├─┬ meta
+ 21K │ │ │ └── lib
+ 11K │ │ ├── owner
+9.4K │ │ ├── deprecations
+7.3K │ │ ├── metal
+7.0K │ │ ├── string
+5.0K │ │ ├── glimmer
+4.9K │ │ ├── routing
+4.8K │ │ ├── utils
+4.5K │ │ ├── error-handling
+4.5K │ │ ├── utility-types
+4.2K │ │ ├── container
+4.2K │ │ ├── browser-environment
+4.1K │ │ └── environment
+182K │ ├─┬ routing
+ 28K │ │ └── lib
+141K │ ├─┬ object
+ 66K │ │ └─┬ lib
+ 62K │ │ └── computed
+114K │ ├─┬ template-compiler
+109K │ │ └─┬ lib
+ 20K │ │ ├── plugins
+4.6K │ │ ├── system
+4.1K │ │ └── -internal
+ 66K │ ├─┬ application
+5.6K │ │ └── lib
+ 52K │ ├─┬ debug
+ 21K │ │ └── lib
+ 31K │ ├─┬ engine
+4.7K │ │ └── lib
+ 27K │ ├─┬ array
+4.8K │ │ └── lib
+ 26K │ ├── runloop
+ 22K │ ├─┬ utils
+ 18K │ │ └── lib
+ 20K │ ├── helper
+ 11K │ ├── destroyable
+9.8K │ ├── instrumentation
+9.3K │ ├── controller
+7.4K │ ├── service
+7.2K │ ├── owner
+6.2K │ ├── component
+5.6K │ ├── canary-features
+5.5K │ ├── modifier
+5.1K │ ├── template-compilation
+5.0K │ ├── enumerable
+5.0K │ ├── test
+4.4K │ ├── template
+4.4K │ ├── renderer
+4.2K │ ├── deprecated-features
+4.1K │ ├── template-factory
+4.1K │ └── version
+705K ├── shared-chunks
+384K ├─┬ @glimmer
+166K │ ├── runtime
+ 60K │ ├── opcode-compiler
+ 30K │ ├── manager
+ 22K │ ├── validator
+ 14K │ ├── program
+ 12K │ ├── reference
+ 11K │ ├── destroyable
+ 10K │ ├─┬ tracking
+4.4K │ │ └── primitives
+ 10K │ ├── util
+8.1K │ ├── node
+7.3K │ ├── global-context
+6.4K │ ├── wire-format
+5.0K │ ├── vm
+4.9K │ ├── encoder
+4.6K │ ├── owner
+4.1K │ └── env
+ 60K ├─┬ ember-testing
+ 55K │ └─┬ lib
+ 14K │ ├── test
+ 14K │ ├── helpers
+ 10K │ ├── ext
+6.4K │ └── adapters
+ 31K ├── backburner.js
+ 24K ├── ember
+ 24K ├── route-recognizer
+ 18K ├─┬ @simple-dom
+ 14K │ └── document
+9.2K ├── dag-map
+4.3K ├── rsvp
+4.3K └── router_jsDetails
|
wagenet
changed the title
wagenet
commented
Jun 9, 2025
| 'for an ArrayProxy inside ObjectProxy that has empty content' | ||
| ); | ||
| } | ||
| // TODO: Add real tests here |
There was a problem hiding this comment.
We should add some tests for this function if we want to keep it.
There was a problem hiding this comment.
the utils are already deprecated -- so I don't know what this would test!
wagenet
commented
Jun 10, 2025
Comment on lines
+1850
to
+1852
| destroy() { | ||
| destroyObservers(this); | ||
| }, |
There was a problem hiding this comment.
Somehow the previous ArrayProxy mixin still caused this to be present even though it wasn't mixed in here. This is slightly concerning.
There was a problem hiding this comment.
Once observers are removed tho 🤔
wagenet
changed the title
NullVoxPopuli
approved these changes
Jun 10, 2025
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this to land in main we will need to have first deprecated
@ember/array/proxy,@ember/object/promise-proxy-mixin, and@ember/object/proxy.